Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix at+get fns #1290

Merged
merged 10 commits into from
Jun 27, 2024
Merged

Fix at+get fns #1290

merged 10 commits into from
Jun 27, 2024

Conversation

goastler
Copy link
Member

@goastler goastler commented Jun 26, 2024 •
edited
Loading

  • finite index check (because nan and inf suck)
  • generic array inference fix (ts infers the array correctly so you don't have to)
  • undefined case handling fix (make sure an array containing an undefined cannot return Exclude<X, undefined>)
  • fix string calling of at fn (wouldn't always pickup string correctly)
  • fix return types with/wo undefined excluded
  • accept readonly arrays in at fn

@prosoponator prosoponator enabled auto-merge (squash) June 26, 2024 15:00
@prosoponator prosoponator merged commit 5b5ade2 into main Jun 27, 2024
9 checks passed
@prosoponator prosoponator deleted the fix-at-get branch June 27, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forgetso forgetso forgetso approved these changes

@HughParry HughParry Awaiting requested review from HughParry HughParry is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goastler @forgetso @prosoponator